Review main Merged

97579[BUGFIX] Style Form Framework elements in Camino theme

Benni Mack CR +2 V +2 Hard +306 −0 updated 11/12/26, 21:05

Commit message

The Camino theme lists the form set as optional dependency and
offers the "Form" content element, but ships no styles for the
markup rendered by the Form Framework. Forms were therefore shown
with unstyled browser defaults, while the frontend login form
already had dedicated styles.

The theme now styles the default form markup: text fields, selects,
checkboxes and radio buttons, file and image uploads, fieldsets,
grid rows, validation errors, descriptions, the summary page and
the navigation buttons. The styles build upon the existing theme
variables, so they follow the selected color scheme and work on
colored content frames.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Georg Ringer +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benni Mack uploaded patch set 1 11/12/26, 14:34

  2. core-ci voted on patch set 1 V +1 11/12/26, 14:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114194

  3. Georg Ringer voted on patch set 1 CR +1 V +1 11/12/26, 15:47

  4. Garvin Hicking voted on patch set 1 CR +2 V +2 11/12/26, 20:54

  5. Garvin Hicking merged patch set 2 11/12/26, 21:05