Review main Merged

97587[TASK] Speed up FormEngine input e2e specs

Benni Mack CR +2 V +2 Easy +25 −15 updated 11/12/26, 20:43

Commit message

The Playwright shards are the longest jobs of the pre-merge pipeline.
Two FormEngine specs stand out: elements-basic-input-date and
elements-basic-input-simple ran 63 tests, each of which opened the
elements_basic record anew through the page tree and the records
module before changing a single field. Opening the record takes
about three times as long as the save that is actually tested.

The cases of a group now share one opened record and run as steps of
one test. Every case still fills, saves and verifies the same values,
and a failing step is reported by its case name.

Measured locally with one worker, the two files drop from 129 to 57
seconds, which shortens the shard they are part of by about a third.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
  • Verified V +2 Done
    • Georg Ringer +2
    • core-ci +1 CI

Issues 1

Files 2

Review log 46

  1. Benni Mack uploaded patch set 1 11/12/26, 20:17

  2. Benni Mack updated the commit message in patch set 2 11/12/26, 20:21

  3. core-ci voted on patch set 1 V +1 11/12/26, 20:31 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114221

  4. core-ci voted on patch set 2 V +1 11/12/26, 20:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114224

  5. Georg Ringer voted on patch set 2 CR +2 V +2 11/12/26, 20:43

  6. Georg Ringer merged patch set 3 11/12/26, 20:43