Review 14.3 Merged

97597[TASK] Reduce repeated fixture setup in functional tests

Benni Mack CR +2 V +2 Easy +25 −23 updated 11/13/26, 14:17

Commit message

Reuse authentication fixtures through database snapshots and reuse
Styleguide demo data on SQLite, including its site configuration and
files. Keep generation on server databases to avoid double-encoding
JSON during snapshot restoration.

Reduce password hashing cost in the reaction test configuration while
retaining real hashing and password verification.

A local SQLite comparison reduces the affected tests from 52.9 to
18.2 seconds with identical assertions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
  • Verified V +2 Done
    • Benni Mack +2
    • core-ci +1 CI

Issues 1

Files 1

Review log 57

  1. Benni Mack commented on patch set 1 11/13/26, 08:20

    Cherry Picked from branch main. The following files contain Git conflicts: * typo3/sysext/reactions/Tests/Functional/Http/Middleware/ReactionResolverTest.php * typo3/sysext/styleguide/Tests/Functional/TcaDataGenerator/GeneratorTest.php
  2. core-ci voted on patch set 1 V -1 11/13/26, 08:25 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114287

  3. Benni Mack uploaded patch set 2 V -1 11/13/26, 14:00

  4. core-ci voted on patch set 2 V +1 11/13/26, 14:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114327

  5. Benni Mack marked it ready for review 11/13/26, 14:17

  6. Benni Mack voted on patch set 2 CR +2 V +2 11/13/26, 14:17

  7. Benni Mack merged patch set 3 11/13/26, 14:17