Review main Work in progress

97599[BUGFIX] Resolve foreign record types in RecordFactory

Benni Mack CR 0 V 0 Normal +161 −10 updated 11/13/26, 10:20

Commit message

TCA types can point to a field of a related record, such as
"file:type" of sys_file_metadata or "uid_local:type" of
sys_file_reference. RecordFactory::createRawRecord() ignored such
types, so records of these tables had no record type and consumers
like the VisibleSchemaFieldsCollector fell back to all columns of
the table instead of the fields of the actual type.

The record type is now fetched from the related record. For
workspace aware tables, the version of the related record in the
current workspace is used. If the pointer field is empty, or the
related record does not exist, is deleted or is deleted in the
current workspace, the record has no type, as before.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/97599/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/99/97599/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Relation chain 2

  1. main 97603[TASK] Introduce RecordTypeResolver and deprecate getTCAtypeValue() Based on this change Work in progress Merge conflict Benni Mack CR 0 V 0 Hard +365 −127
  2. 97599 [BUGFIX] Resolve foreign record types in RecordFactory This change

Merge conflicts 1

Issues 2

Files 4

Review log 35

  1. Benni Mack uploaded patch set 1 11/13/26, 09:15

  2. core-ci voted on patch set 1 V +1 11/13/26, 09:21 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114291

  3. Benni Mack uploaded patch set 2 V +1 11/13/26, 10:09

  4. Benni Mack marked it work in progress 11/13/26, 10:18

  5. core-ci voted on patch set 2 V +1 11/13/26, 10:20 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114299