Review main Merged

97608[BUGFIX] Set date of Date form element to midnight

Josua Vogel CR +2 V +2 Easy +45 −2 updated 11/18/26, 07:53

Commit message

The Date form element converts the submitted value with the format
"Y-m-d". DateTime::createFromFormat() fills the missing time fields
with the current time, so the value carries the time of the request
and finishers like SaveToDatabase store it.

This is inconsistent, as the DateRange validator already sets the
value to midnight. The format "!Y-m-d" is now used, which resets the
time to 00:00:00 in every case.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 2

Files 3

Review log 710

  1. Josua Vogel uploaded patch set 1 11/13/26, 11:01

  2. Josua Vogel updated the commit message in patch set 2 11/13/26, 11:04

  3. Josua Vogel updated the commit message in patch set 3 11/13/26, 11:05

  4. core-ci voted on patch set 1 V +1 11/13/26, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114307

  5. core-ci voted on patch set 2 V +1 11/13/26, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114308

  6. core-ci voted on patch set 3 V +1 11/13/26, 11:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114309

  7. Benni Mack voted on patch set 3 CR +1 V +1 11/13/26, 13:12

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/15/26, 01:00

  9. Benni Mack voted on patch set 3 CR +2 V +2 11/18/26, 07:53

  10. Benni Mack merged patch set 4 11/18/26, 07:53