Review main Ready for review

97648[BUGFIX] Support translation domain labels in Extbase validators

Georg Ringer CR +1 V +1 Normal +103 −6 updated 11/21/26, 07:39

Commit message

Error messages of Extbase validators are translated if they are
label references. Besides the "LLL:" prefix, a message in the form
"<domain>:<key>" is now recognized as a reference, if the domain
resolves to an existing label resource. Other strings are still used
as plain text.

The check is provided by TranslationDomainMapper->isLabelReference()
and used by AbstractValidator and ConstraintDecoratingValidator.
A reference whose label cannot be found is used as message instead
of an empty string.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/48/97648/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/48/97648/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Josua Vogel +1
  • Verified V +1 Needs a vote
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 79

  1. Georg Ringer uploaded patch set 1 11/14/26, 13:58

  2. Georg Ringer commented on patch set 1 11/14/26, 13:59

    This change is ready for review.
  3. core-ci voted on patch set 1 V +1 11/14/26, 14:05 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114456

  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/15/26, 01:24

  5. Josua Vogel commented on patch set 1 11/20/26, 12:20

    Important-108013-TranslationDomainLabelsInExtbaseValidatorMessages.rst:36

    this is internal, so imo it shouldn´t be part of the changelog
  6. Georg Ringer uploaded patch set 2 CR +1 V +1 11/20/26, 19:45

  7. Georg Ringer commented on patch set 2 11/20/26, 19:45

    Important-108013-TranslationDomainLabelsInExtbaseValidatorMessages.rst:36 Reply

    Done
  8. core-ci voted on patch set 2 V +1 11/20/26, 19:54 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115085

  9. Josua Vogel voted on patch set 2 CR +1 V +1 11/21/26, 07:39