Review main Merged

97650[TASK] Reuse authentication middleware database fixtures

Wouter Wolters CR +2 V +2 Normal +29 −25 updated 11/15/26, 11:04

Commit message

Create the password hashes and shared user records once per test class
and restore a database snapshot for subsequent tests. Keep creating the
middleware and request handlers separately for every test.

Both middleware classes still use real password hashing and
verification.
A local SQLite benchmark drops from 18.03 s to 9.76 s for the same
21 tests and 85 assertions.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 810

  1. Wouter Wolters uploaded patch set 1 11/14/26, 14:51

  2. Wouter Wolters updated the commit message in patch set 2 11/14/26, 15:10

  3. Wouter Wolters wrote 11/14/26, 15:10

    Unset private
  4. core-ci voted on patch set 2 V +1 11/14/26, 15:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114459

  5. Wouter Wolters updated the commit message in patch set 3 V +1 11/14/26, 17:09

  6. Wouter Wolters marked it ready for review 11/14/26, 17:09

  7. core-ci voted on patch set 3 V +1 11/14/26, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114468

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/15/26, 01:24

  9. Benni Mack voted on patch set 3 CR +2 V +2 11/15/26, 11:04

  10. Benni Mack merged patch set 4 11/15/26, 11:04