Review main Merged

97654[BUGFIX] Prevent endless recursion in record statistics

Oli Bartsch CR +2 V +2 Normal +65 −0 updated 11/14/26, 21:04

Commit message

DatabaseIntegrityCheck::genTree() follows both the pid and the
t3ver_oid relation of pages, but did not track which pages it had
already processed. Broken data, such as a page whose t3ver_oid points
to its own uid or two pages pointing to each other via t3ver_oid,
therefore led to endless recursion. On MySQL this ends in an
exhausted max_prepared_stmt_count, since every recursion level keeps
its query result open.

genTree() now skips pages that are already registered. This also
stops workspace versions, which carry the live pid, from being counted
twice in the doktype and hidden statistics.

Review

  • Code review CR +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Georg Ringer +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 56

  1. Oli Bartsch uploaded patch set 1 11/14/26, 16:06

  2. core-ci voted on patch set 1 V +1 11/14/26, 16:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114464

  3. Benni Mack commented on patch set 1 CR +1 V +1 11/14/26, 17:23

    tests check out to be fine.
  4. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/14/26, 20:35

  5. Georg Ringer voted on patch set 1 CR +2 V +2 11/14/26, 20:44

  6. Georg Ringer merged patch set 2 11/14/26, 21:04