Review main Merged

97678[TASK] Stop creating the temporary folder in fileadmin

Benni Mack CR +2 V +2 Normal +110 −26 updated 11/18/26, 07:07

Commit message

The folder structure check of the Install Tool and the "Installation"
status report created fileadmin/_temp_/ with an .htaccess file,
although no Core code has used that folder for a long time. As the
Install Tool kept creating it again, editors and administrators found
a folder in the file list they could neither use nor get rid of.

The folder fileadmin/user_upload/_temp_/importexport/ is still part of
the folder structure, as EXT:impexp uses it and only the folder
structure check protects it with an .htaccess file.

The template file fileadmin-temp-htaccess is kept, as
Testbase::provideInstance() of the testing framework copies it.

The end-to-end upload test now writes its upload file to the
temporary directory of the operating system instead of the removed
folder.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Georg Ringer +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 6

Review log 67

  1. Benni Mack uploaded patch set 1 11/15/26, 15:22

  2. core-ci voted on patch set 1 V +1 11/15/26, 15:29 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114545

  3. Benni Mack marked it ready for review 11/17/26, 13:49

  4. Georg Ringer voted on patch set 1 CR +1 V +1 11/17/26, 21:41

  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/18/26, 01:35

  6. Benni Mack voted on patch set 1 CR +2 V +2 11/18/26, 07:06

  7. Benni Mack merged patch set 2 11/18/26, 07:07