Review main Merged

97680[BUGFIX] Keep crop area of newly configured crop variants

Simon Schaufelberger CR +2 V +2 Easy +42 −6 updated 11/18/26, 13:45

Commit message

When a crop variant is added to a TCA field after editors cropped
existing image references, the crop tool copied the crop area of the
first persisted crop variant onto the new variant. The frontend, which
does not know the TCA configuration, renders the full image for such a
variant, so backend and frontend showed different crops. Saving the
form then persisted the wrongly merged areas.

Only merge persisted areas of crop variants that exist in the
persisted crop value. Variants configured later keep the crop area of
the crop tool configuration, which is the full image.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Simon Schaufelberger uploaded patch set 1 11/15/26, 16:29

  2. core-ci voted on patch set 1 V +1 11/15/26, 16:39 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114550

  3. Benni Mack voted on patch set 1 CR +1 V +1 11/18/26, 11:39

  4. Oli Bartsch voted on patch set 1 CR +2 V +2 11/18/26, 13:45

  5. Oli Bartsch merged patch set 2 11/18/26, 13:45