Review main Merged

97684[TASK] Avoid optional sudo dialog timeouts in Playwright

Wouter Wolters CR +2 V +2 Easy +5 −7 updated 11/18/26, 09:21

Commit message

Replace the five-second optional sudo wait when updating user TSconfig
with a wait for verification or a saved, clean form. Preserve password
verification and propagate errors instead of swallowing them.

Repeated local SQLite runs reduce the two caller specs from 29.89 s to
15.38 s.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 1520

  1. Wouter Wolters uploaded patch set 1 11/15/26, 19:40

  2. Wouter Wolters updated the commit message in patch set 2 11/15/26, 19:46

  3. Wouter Wolters marked it ready for review 11/15/26, 19:46

  4. Wouter Wolters wrote 11/15/26, 19:46

    Unset private
  5. core-ci voted on patch set 2 V +1 11/15/26, 19:53 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114562

  6. Wouter Wolters rebased onto patch set 3 V +1 11/17/26, 13:50

  7. Oliver Klee voted on patch set 3 V +1 11/17/26, 13:55

  8. Simon Schaufelberger voted on patch set 3 CR +1 V +1 11/17/26, 14:00

  9. Simon Schaufelberger commented on patch set 3 11/17/26, 14:00

    Thank you for making the tests much faster!
  10. core-ci voted on patch set 3 V -1 11/17/26, 14:06 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114736

  11. Oliver Klee voted on patch set 3 V 0 11/17/26, 14:43

  12. Wouter Wolters rebased onto patch set 4 CR +1 V +1 11/17/26, 15:13

  13. core-ci voted on patch set 4 V -1 11/17/26, 15:26 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114748

  14. Wouter Wolters rebased onto patch set 5 V -1 11/17/26, 19:51

  15. core-ci voted on patch set 5 V -1 11/17/26, 19:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114786

  16. Wouter Wolters rebased onto patch set 6 V -1 11/17/26, 22:23

  17. core-ci voted on patch set 6 V +1 11/17/26, 22:30 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114796

  18. Simon Schaufelberger voted on patch set 6 CR +1 V +1 11/17/26, 23:02

  19. Benni Mack voted on patch set 6 CR +2 V +2 11/18/26, 09:21

  20. Benni Mack merged patch set 7 11/18/26, 09:21