Review main Abandoned

97688[BUGFIX] Keep translate wizard exclusions complete

Himanshu Nitsan CR 0 V -1 Normal +38 −20 updated 11/17/26, 07:03

Commit message

Free-mode destination records store l10n_source = 0.
Collecting those values with while ($uid = fetchOne())
stopped on the first zero, so later connected sources
were never excluded and already translated elements
reappeared in the wizard.

Select only positive l10n_source values via
fetchFirstColumn() for the exclusion list.

Review

  • Code review CR 0
  • Verified V -1
    • Oli Bartsch -1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Himanshu Nitsan uploaded patch set 1 11/16/26, 08:07

  2. core-ci voted on patch set 1 V +1 11/16/26, 08:14 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114596

  3. Oli Bartsch commented on patch set 1 V -1 11/16/26, 16:29

    This looks like a duplicate of https://review.typo3.org/c/Packages/TYPO3.CMS/+/66905. Could you please check whether we should continue there instead?
  4. Himanshu Nitsan commented on patch set 1 11/17/26, 07:02

    Reply

    Thanks, you're right. #111423 hits the same l10n_source = 0 loop issue as #92937. I'll abandon this change in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/66905.
  5. Himanshu Nitsan abandoned the change 11/17/26, 07:03

    Abandoned in favor of https://review.typo3.org/c/Packages/TYPO3.CMS/+/66905 (Resolves: #92937), which also covers the l18n_parent fallback.