Review 13.4 Merged

97691[TASK] Raise phpstan/phpstan to ^2.3.6

Oli Bartsch CR +2 V +2 Easy +18 −6 updated 11/16/26, 13:02

Commit message

phpstan 2.3.6 takes the return type of memcache_connect() from the
phpstorm-stubs, which declare Memcache only, although the function
returns false on a failed connection. On 13.4, where doc types are
still treated as certain, this reports the connection check in
ConfigurationStatus as always true.

The code is correct, so both findings go to the baseline.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 1

Files 3

Review log 45

  1. Oli Bartsch uploaded patch set 1 11/16/26, 11:52

  2. core-ci voted on patch set 1 V +1 11/16/26, 11:58 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114614

  3. Josua Vogel voted on patch set 1 CR +1 V +1 11/16/26, 12:09

  4. Benni Mack voted on patch set 1 CR +2 V +2 11/16/26, 13:02

  5. Benni Mack merged patch set 2 11/16/26, 13:02