Review main Merged

977[BUGFIX] tcaTree: make own record unselectable

Steffen Ritter CR +2 V +2 Easy +36 −1 updated 06/03/13, 20:49

Commit message

Relations to an own record is not useful. You could exclude is via tca "andWhere"
This is not nice, because you wouldn't  see the whole tree.
Just make the own record unselectable.

Review

  • Code review CR +2
    • Jigal van Hemert +2
    • Tolleiv Nietsch +1
    • Kay Strobach +1
    • Philipp Gampe +1
  • Verified V +2
    • Jigal van Hemert +2
    • Philipp Gampe +1

Files 3

Review log 6

  1. Gerrit wrote 04/06/11, 17:37

    Your change could not be merged due to a path conflict. Please merge (or rebase) the change locally and upload the resolution for review.
  2. Tolleiv Nietsch commented on patch set 1 04/06/11, 17:37

    Looks good to me, but someone else must approve
  3. Kay Strobach commented on patch set 1 04/06/11, 17:37

    Looks good to me, but someone else must approve
  4. Jigal van Hemert commented on patch set 1 V 0 04/06/11, 17:37

    by team member; Looks good to me, approved Works for me. Go ahead and submit it!
  5. Philipp Gampe commented on patch set 1 04/06/11, 17:37

    Verified; Looks good to me, but someone else must approve Without "andWhere" editors can create cycles which will not show up in normal tree. Actually editors should not be able to select anything below the current item, even if it shows up. Still the patch does what it is supposed to do :) +1
  6. Jigal van Hemert merged patch set 1 04/06/11, 17:37