Review 13.4 Merged

97714[SECURITY] Prevent adding online media to the fallback storage

Benjamin Franzke CR +2 V +2 Hard +367 −0 updated 11/17/26, 10:30

Commit message

Online media could be added to an arbitrary folder given
in the request. Using a folder of the fallback storage
(e.g. "0:/"), which is not subject to file mount and
permission checks, any backend user could create files
in the public web root.

A target folder in the fallback storage is now ignored
and the user's default upload folder is used instead,
like for an invalid target folder.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2

Issues 2

Files 6

Review log 2

  1. Benjamin Franzke wrote 11/17/26, 10:28

    Hashtag added: sec-2026-11
  2. Benjamin Franzke merged patch set 2 11/17/26, 10:30