Review 14.3 Merged

97730[SECURITY] Enforce object selector consistency in FileDumpController

Benjamin Franzke CR +2 V +2 Hard +236 −27 updated 11/17/26, 10:35

Commit message

FileDumpController signs only parameter values in the dumpFile
token, not parameter keys. A token minted for `t=f&f=<uid>` was
therefore also accepted after swapping the selector, e.g. for
`t=f&r=<uid>`, since the signed string stays identical.

This let an attacker reuse a valid sys_file token to instead dump
the sys_file_reference or sys_file_processedfile row at the same
numeric UID, bypassing access restrictions on the actual object
that gets resolved and streamed.

Reject the request unless exactly one of the selectors `f`, `r`
or `p` is present and it matches the signed `t` value, before the
file object is resolved.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2

Issues 1

Files 10

Review log 2

  1. Benjamin Franzke wrote 11/17/26, 10:31

    Hashtag added: sec-2026-11
  2. Benjamin Franzke merged patch set 2 11/17/26, 10:35