Review main Merged

97738[SECURITY] Lock installer on already configured instances

Benjamin Franzke CR +2 V +2 Normal +86 −10 updated 11/17/26, 10:56

Commit message

The installer (first-install wizard) could be re-opened
on an already configured instance by placing a
`FIRST_INSTALL` marker file into the public web root. An
attacker able to create such a file could then reach the
installer anonymously, rewrite the database connection,
create a new backend admin and system maintainer.

The marker file alone is no longer sufficient. A new
global setting `SYS/isInstalling` is stored in
settings.php and defaults to false. A fresh installation
sets it to true while running and back to false on
completion. `EnableFileService::isFirstInstallAllowed()`
now requires both a marker file and an instance that is
not yet installed (no settings.php, or isInstalling is
true), so a configured instance can no longer be sent
back into the installer through a web-writable file.
Instances upgraded from an older version are treated
as not installing.

As additional hardening, the `FIRST_INSTALL` marker file
name matching is restricted to the exact file names
`FIRST_INSTALL` and `FIRST_INSTALL.txt`.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2

Issues 2

Files 7

Review log 2

  1. Benjamin Franzke wrote 11/17/26, 10:55

    Hashtag added: sec-2026-11
  2. Benjamin Franzke merged patch set 2 11/17/26, 10:56