Review main Merged

97742[SECURITY] Exclude unvalidated arguments from page cache id

Benjamin Franzke CR +2 V +2 Normal +109 −1 updated 11/17/26, 10:57

Commit message

PageArgumentValidator treats a non-scalar or empty cHash as
missing, so its query arguments are not validated. In the
legacy mode without enforced cHash validation, caching then
stays enabled, relying on the arguments not being part of
the page cache identifier.

The page cache identifier however included the arguments as
soon as any truthy cHash argument was given, e.g. an array.
Anonymous users were therefore able to create an unlimited
number of page cache entries and uncached page renderings
by sending "cHash[]" with arbitrary values.

The page cache identifier now uses the same condition as the
validator, and only includes the arguments for a non-empty
scalar cHash, which has been validated before.

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2

Issues 1

Files 2

Review log 2

  1. Benjamin Franzke wrote 11/17/26, 10:55

    Hashtag added: sec-2026-11
  2. Benjamin Franzke merged patch set 2 11/17/26, 10:57