Review main Merged

97745[SECURITY] Allow restricting feed hosts of RSS widget

Benjamin Franzke CR +2 V +2 Hard +466 −14 updated 11/17/26, 11:09

Commit message

The RSS widget fetched the feed url of its settings with
GeneralUtility::getUrl(). Backend users were therefore able
to let the server request internal hosts. As the pattern
validating the setting is not anchored, urls of other
schemes containing "http://" passed the validation as well,
and were read with file_get_contents(). The settings also
overrode the feed url of the widget registration, although
the setting is readonly then.

Feeds are now fetched with the RequestFactory by http(s)
only, using the request context "dashboard_rss". Other
sources, such as local files, are not read anymore, also
not for the feed url of the widget registration. Such urls
fail the validation of the setting since TYPO3 v14.0 anyway.
The feed url of the widget registration is always used if
defined, and the pattern validating the setting is anchored.

Requests to internal hosts are only prevented once the
allowed hosts are configured in the new opt-in setting
[HTTP][allowed_hosts][dashboard_rss]. Configuring it is
strongly recommended. The widget shows a notice for hosts
and redirect targets that are not allowed, as well as for
feed urls of the settings that do not use http(s).

Review

  • Code review CR +2 Done
    • Benjamin Franzke +2
  • Verified V +2 Done
    • Benjamin Franzke +2

Issues 1

Files 9

Review log 23

  1. Benjamin Franzke wrote 11/17/26, 10:55

    Hashtag added: sec-2026-11
  2. Benjamin Franzke merged patch set 2 11/17/26, 10:57

  3. core-ci voted on patch set 1 V +1 11/17/26, 11:09 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114719