Review main Merged

97746[TASK] Share password check of native authenticators

Oli Bartsch CR +2 V +2 Hard +402 −171 updated 11/17/26, 16:06

Commit message

The native password authenticators of backend and frontend carried
identical copies of the request token check, the password verification,
the creation of a replacement hash and the timing mitigation for
unknown users.

These parts now live in the internal PasswordCredentialVerifier in the
Security namespace, used by both authenticators. It does not persist
anything: storing a replaced password hash and the login timestamp is
done by the LocalIdentityProvider the user record was looked up with,
so the verifier makes no assumption about where users are stored.

The flow of a login, its logging and its events stay with the
authenticators. Behavior is unchanged.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Josua Vogel +1
  • Verified V +2 Done
    • Benni Mack +2
    • Josua Vogel +1
    • core-ci +1 CI

Issues 2

Files 7

Review log 711

  1. Oli Bartsch uploaded patch set 1 11/17/26, 11:52

  2. core-ci voted on patch set 1 V +1 11/17/26, 12:02 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114727

  3. Benni Mack uploaded patch set 2 V +1 11/17/26, 15:32

  4. Oli Bartsch uploaded patch set 3 11/17/26, 15:36

  5. Benni Mack uploaded patch set 4 11/17/26, 15:40

  6. core-ci voted on patch set 2 V +1 11/17/26, 15:43 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114751

  7. core-ci voted on patch set 3 V +1 11/17/26, 15:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114752

  8. core-ci voted on patch set 4 V +1 11/17/26, 15:48 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114754

  9. Josua Vogel voted on patch set 4 CR +1 V +1 11/17/26, 16:03

  10. Benni Mack voted on patch set 4 CR +2 V +2 11/17/26, 16:06

  11. Benni Mack merged patch set 5 11/17/26, 16:06