Review main Merged

97762[TASK] Quote forwarded arguments in runTests.sh

Benjamin Kott CR +2 V +2 Easy +12 −15 updated 11/18/26, 10:56

Commit message

The e2e suites, lintTypescript and phpstanGenerateBaseline passed the
remaining arguments on as one string, so word splitting broke
--grep "a pattern" into several arguments and Playwright read the
extra words as file filters. The commands are now built as arrays,
or get the arguments as positional parameters where a shell is needed.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 810

  1. Benjamin Kott uploaded patch set 1 11/17/26, 17:34

  2. core-ci voted on patch set 1 V +1 11/17/26, 17:41 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114769

  3. Benjamin Franzke commented on patch set 1 CR +1 V +1 11/18/26, 09:22

    runTests.sh:1497

    Nice trick: `sh` isn't the command here (that's in `-c "…"`), but only the *name* of the shell.
  4. Benjamin Franzke commented on patch set 1 11/18/26, 09:23

    TASK not BUGFIX ;)
    Can you backport to 13.4 as well? lintTypescript and phpstanGenerateBaseline should be affected there as well.
  5. Benjamin Kott updated the commit message in patch set 2 CR +1 V +1 11/18/26, 10:25

  6. Benjamin Kott commented on patch set 2 11/18/26, 10:30

    Reply

    Whatever

    Reply

    Done
  7. Benjamin Franzke voted on patch set 2 CR +1 V +1 11/18/26, 10:31

  8. core-ci voted on patch set 2 V +1 11/18/26, 10:32 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114843

  9. Benjamin Kott voted on patch set 2 CR +2 V +2 11/18/26, 10:35

  10. Benjamin Kott merged patch set 3 11/18/26, 10:56