Review main Merged

97763[BUGFIX] Read record type label from related record

Benjamin Kott CR +2 V +2 Normal +57 −4 updated 11/18/26, 19:04

Commit message

For a type pointer like "uid_local:type", RecordTypeLabelResolver now
reads the type from the related record, as FormEngine does, instead of
casting the local relation value. A group field processed by FormEngine
is a list of relation items, which raised an "Array to string
conversion" warning when editing a file reference.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Oli Bartsch +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Benjamin Kott uploaded patch set 1 11/17/26, 17:39

  2. core-ci voted on patch set 1 V +1 11/17/26, 17:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114770

  3. Benjamin Kott uploaded patch set 2 V +1 11/18/26, 17:09

  4. core-ci voted on patch set 2 V +1 11/18/26, 17:18 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114893

  5. Oli Bartsch commented on patch set 2 CR +1 V +1 11/18/26, 17:47

    RecordTypeLabelResolver.php:98

    I remember that at other places I always checked whether $foreignTable and $foreignField actually exist. However since getRecord() will just return null, I think it is fine this way.
  6. Benjamin Kott voted on patch set 2 CR +2 V +2 11/18/26, 18:27

  7. Benjamin Kott commented on patch set 2 11/18/26, 18:27

    RecordTypeLabelResolver.php:98 Reply

    Acknowledged
  8. Benjamin Kott merged patch set 3 11/18/26, 19:04