Review main Merged

97764[BUGFIX] Type Viewport.Loader as the Loader class

Benjamin Kott CR +2 V +2 Normal +62 −1 updated 11/18/26, 09:10

Commit message

Viewport.Loader holds the Loader class, whose members are static, but
was declared as a Loader instance. TypeScript callers of
Viewport.Loader.start() and finish() failed with TS2576 and had to
cast; the emitted JavaScript does not change.

Review

  • Code review CR +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
  • Verified V +2 Done
    • Benjamin Kott +2
    • Benjamin Franzke +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 45

  1. Benjamin Kott uploaded patch set 1 11/17/26, 17:39

  2. core-ci voted on patch set 1 V +1 11/17/26, 17:47 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114771

  3. Benjamin Franzke voted on patch set 1 CR +1 V +1 11/18/26, 08:53

  4. Benjamin Kott voted on patch set 1 CR +2 V +2 11/18/26, 09:02

  5. Benjamin Kott merged patch set 2 11/18/26, 09:10