Review main Merged

97770[TASK] Speed up Install Tool authentication in e2e tests

Wouter Wolters CR +2 V +2 Easy +4 −4 updated 11/18/26, 19:33

Commit message

Use a lower Argon2i time cost for the fixed Install Tool test password
in Composer and classic installations. The browser still verifies the
password through the normal login flow.

Across two fresh Composer runs per variant, the Install Tool spec
averaged 66.05 s before the change and 53.09 s after it.

Review

  • Code review CR +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Benni Mack +2
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 67

  1. Wouter Wolters uploaded patch set 1 11/17/26, 22:41

  2. core-ci voted on patch set 1 V +1 11/17/26, 22:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114798

  3. Simon Schaufelberger commented on patch set 1 11/18/26, 00:53

    setupAcceptanceClassic.sh:45

    why not even 1 or 2?
  4. Wouter Wolters commented on patch set 1 11/18/26, 18:01

    setupAcceptanceClassic.sh:45 Reply

    I chose 4 because it’s PHP’s default in the e2e image and the minimum TYPO3 accepts when configuring its Argon2 hasher. The fixture uses a precomputed hash, so that configuration check doesn’t apply directly. I verified that 1 and 2 work with password_hash() and password_verify() in our current image, but the libsodium Argon2i implementation rejects both for hash generation. At 4, the Install Tool spec already saves about 13 seconds (19.6%).
  5. Simon Schaufelberger voted on patch set 1 CR +1 V +1 11/18/26, 18:45

  6. Benni Mack voted on patch set 1 CR +2 V +2 11/18/26, 19:33

  7. Benni Mack merged patch set 2 11/18/26, 19:33