Review main Merged

97785[BUGFIX] Redirect after creating multiple pages

Oli Bartsch CR +2 V +2 Normal +137 −2 updated 11/18/26, 13:51

Commit message

The "Create multiple pages" wizard created the pages and rendered its
result view in the same response to the POST request. Deleting a
record through the context menu reloads the content frame with
location.reload(). That reload sent the form data again, so the
pages were created a second time.

The controller now redirects with 303 to the pages_new route after
creating the pages and passes the outcome as the "created" argument.
The result view is rendered on that GET request. Reloading the
content frame therefore no longer creates the pages again.

Review

  • Code review CR +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
  • Verified V +2 Done
    • Oli Bartsch +2
    • Benni Mack +1
    • Simon Schaufelberger +1
    • core-ci +1 CI

Issues 1

Files 2

Review log 68

  1. Oli Bartsch uploaded patch set 1 11/18/26, 10:01

  2. core-ci voted on patch set 1 V +1 11/18/26, 10:12 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114840

  3. Oli Bartsch uploaded patch set 2 V +1 11/18/26, 10:14

  4. core-ci voted on patch set 2 V +1 11/18/26, 10:25 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114841

  5. Benni Mack voted on patch set 2 CR +1 V +1 11/18/26, 10:31

  6. Simon Schaufelberger voted on patch set 2 CR +1 V +1 11/18/26, 12:23

  7. Oli Bartsch voted on patch set 2 CR +2 V +2 11/18/26, 13:51

  8. Oli Bartsch merged patch set 3 11/18/26, 13:51