Review main Ready for review

97790[BUGFIX] Purge _TRANSLATION_SOURCE before workspace overlay SQL

Himanshu Nitsan CR 0 V 0 Easy +20 −0 updated 11/18/26, 12:15

Commit message

Language overlays attach the virtual _TRANSLATION_SOURCE property to
page rows. versionOL() builds SELECT fields from the row keys after
purgeComputedProperties(), but that list omitted _TRANSLATION_SOURCE,
so workspace preview of a translated page queried a non-existent
column and failed on MariaDB/MySQL.

Add _TRANSLATION_SOURCE to COMPUTED_PROPERTY_NAMES so it is stripped
like other virtual page properties.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/97790/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/90/97790/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 1

Issues 1

Files 2

Review log 12

  1. Himanshu Nitsan uploaded patch set 1 11/18/26, 12:05

  2. core-ci voted on patch set 1 V +1 11/18/26, 12:15 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114872