Review main Ready for review

97791[BUGFIX] Remove empty actions from ComponentGroup

Markus Hofmann CR 0 V 0 Normal +206 −4 updated 11/18/26, 13:06

Commit message

ComponentGroup::add() accepts null as a placeholder for actions
that are not available for a record, e.g. "moveUp" for the first
record of a sortable table. remove() checked with isset(), which is
false for null, so such actions were never removed. As a result,
removeAction() and moveActionTo() of
ModifyRecordListRecordActionsEvent and ProcessFileListActionsEvent
kept them, misaligning the record list rows.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/91/97791/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/91/97791/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Issues 1

Files 4

Review log 12

  1. Markus Hofmann uploaded patch set 1 11/18/26, 12:54

  2. core-ci voted on patch set 1 V +1 11/18/26, 13:06 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114877