97808[BUGFIX] Evaluate conditions with unresolved constants in strings
Commit message
Test this change
Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch
- Check out patch set 1
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/08/97808/1 && git checkout FETCH_HEAD - Cherry-pick onto main
-
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/08/97808/1 && git cherry-pick FETCH_HEAD
Review
-
Code review CR 0 Needs a vote
-
Verified V 0 Needs a vote
- core-ci +1 CI
Issues 2
Files 2
Review log 45
-
Georg Ringer uploaded patch set 1 11/18/26, 21:15
-
Georg Ringer commented on patch set 1 11/18/26, 21:17
This change is ready for review. -
core-ci voted on patch set 1 V +1 11/18/26, 21:24 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/114929
-
Benni Mack commented on patch set 1 11/18/26, 21:31
Unresolved
sounds similar to this change https://review.typo3.org/c/Packages/TYPO3.CMS/+/95682 -
Manfred Egger commented on patch set 1 11/19/26, 06:50
Unresolved
If there is a condition with an unresolved constant AND invalid syntax - wouldn't this change just notice about the missing constant instead of erroring on the invalid syntax? Shouldn't the invalid syntax be more important in this case?