Review main Ready for review

97844[BUGFIX] Use resolved connection params in DoctrineTransportFactory

Oli Bartsch CR 0 V -1 Normal +215 −3 updated 11/19/26, 14:11

Commit message

DoctrineTransportFactory creates a native Doctrine DBAL connection
from the raw Default connection configuration. It skipped the
normalisation ConnectionPool applies: the "port" parameter was not
cast to an integer and a DSN "url" was not parsed. If the port is
configured as a string, as happens in DDEV or with environment-based
configuration, the mysqli driver passes it to mysqli::real_connect()
and every message sent through the Doctrine transport fails with a
TypeError. A url-based configuration fails as no driver is given.

The factory now takes the parameters already resolved by the
ConnectionPool for the Default connection and still creates a native
DBAL connection from them.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 2
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/44/97844/2 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/44/97844/2 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V -1 Blocked
    • core-ci -1 CI

Merge conflicts 1

Issues 1

Files 4

Review log 24

  1. Oli Bartsch uploaded patch set 1 11/19/26, 13:50

  2. core-ci voted on patch set 1 V -1 11/19/26, 13:58 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115011

  3. Oli Bartsch uploaded patch set 2 V -1 11/19/26, 14:00

  4. core-ci voted on patch set 2 V -1 11/19/26, 14:11 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115016