Review main Ready for review

97847[TASK] Simplify removing trailing slash in GeneralUtility::rmdir()

Chris Müller CR 0 V 0 Easy +1 −1 updated 11/19/26, 19:56

Commit message

There is no need to use a regular expression to remove
a trailing slash from the path.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 1
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/47/97847/1 && git checkout FETCH_HEAD
Cherry-pick onto main
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/47/97847/1 && git cherry-pick FETCH_HEAD

Review

  • Code review CR 0 Needs a vote
  • Verified V 0 Needs a vote
    • core-ci +1 CI

Merge conflicts 2

Issues 1

Files 1

Review log 34

  1. Chris Müller uploaded patch set 1 11/19/26, 15:39

  2. core-ci voted on patch set 1 V +1 11/19/26, 15:46 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115023

  3. Markus Klein commented on patch set 1 11/19/26, 19:45

    GeneralUtility.php:1757

    not sure if it matters, but this removes ALL trailing slashes, whereas the old code only removes 1
  4. Chris Müller commented on patch set 1 11/19/26, 19:56

    GeneralUtility.php:1757 Reply Unresolved

    I don't think that this matters as below the path (without trailing slash) is checked via file_exists().