Review 13.4 Merged

97856[TASK] Avoid redundant null coalescing in indexed_search controller

Oli Bartsch CR +2 V +2 Easy +3 −2 updated 11/20/26, 11:52

Commit message

phpstan 2.3.7 narrows the array after the first offset check and
reports the second "?? ''" on "_freeIndexUid" as always existing,
which breaks the nightly phpstan run with highest dependencies.

Read the value once into a local variable instead.

Review

  • Code review CR +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
  • Verified V +2 Done
    • Garvin Hicking +2
    • Oliver Klee +1
    • Josua Vogel +1
    • Ravi Sachaniya +1
    • core-ci +1 CI

Issues 1

Files 1

Review log 67

  1. Oli Bartsch uploaded patch set 1 11/20/26, 10:38

  2. core-ci voted on patch set 1 V +1 11/20/26, 10:45 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115066

  3. Josua Vogel voted on patch set 1 CR +1 V +1 11/20/26, 10:52

  4. Oliver Klee voted on patch set 1 CR +1 V +1 11/20/26, 10:54

  5. Ravi Sachaniya voted on patch set 1 CR +1 V +1 11/20/26, 11:08

  6. Garvin Hicking voted on patch set 1 CR +2 V +2 11/20/26, 11:52

  7. Garvin Hicking merged patch set 2 11/20/26, 11:52