Review 14.3 Ready for review

97859[BUGFIX] Make form editor stage elements accessible

Garvin Hicking CR +1 V +1 Normal +84 −6 updated 11/20/26, 14:15

Commit message

The stage element box now uses role="group" instead of role="button",
because it contains the toolbar buttons and axe reported
nested-interactive. Enter and Space are handled only when the box
itself has focus, so the toolbar buttons keep their own keyboard
action. An explicit "Edit" button opens the element in the inspector,
and the whole box shows a pointer cursor independent of sorting.

Test this change

Run a command in your clone of the TYPO3 Core. Then try what the change does and vote on Verified in Gerrit. How to review a patch

Check out patch set 3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/59/97859/3 && git checkout FETCH_HEAD
Cherry-pick onto 14.3
git fetch https://review.typo3.org/Packages/TYPO3.CMS refs/changes/59/97859/3 && git cherry-pick FETCH_HEAD

Review

  • Code review CR +1 Needs a vote
    • Garvin Hicking +1
  • Verified V +1 Needs a vote
    • Garvin Hicking +1
    • core-ci +1 CI

Issues 1

Files 9

Review log 58

  1. Garvin Hicking commented on patch set 1 11/20/26, 12:53

    Cherry Picked from branch main. The following files contain Git conflicts: * Build/tests/playwright/fixtures/BackendEnvironment.csv * typo3/sysext/form/Resources/Public/JavaScript/backend/form-editor/stage-component.js
  2. Garvin Hicking commented on patch set 2 11/20/26, 12:55

    Published edit on patch set 1.
  3. Garvin Hicking marked it ready for review 11/20/26, 12:55

  4. core-ci voted on patch set 2 V -1 11/20/26, 13:08 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115076

  5. Garvin Hicking uploaded patch set 3 V -1 11/20/26, 13:36

    backport
  6. core-ci voted on patch set 3 V +1 11/20/26, 13:42 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115080

  7. core-ci voted on patch set 1 V -1 11/20/26, 13:55 Core CI is not happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/115075

  8. Garvin Hicking voted on patch set 3 CR +1 V +1 11/20/26, 14:15