Review TYPO3_4-5 Merged

9799[BUGFIX] tx_rsaauth_sv1::authUser() gives PHP notice

Steffen Müller CR +2 V +2 Easy +2 −2 updated 06/03/13, 20:49

Commit message

PHP Runtime Notice: Declaration of tx_rsaauth_sv1::authUser() should
be compatible with that of tx_sv_auth::authUser().

Review

  • Code review CR +2
    • Georg Ringer +2
    • Oliver Klee +1
    • Xavier Perseguers +1
    • Philipp Gampe +1
  • Verified V +2
    • Georg Ringer +2
    • Xavier Perseguers +1

Files 2

Review log 5

  1. Oliver Klee commented on patch set 1 05/08/12, 15:35

    Looks good to me, but someone else must approve
  2. Xavier Perseguers commented on patch set 1 05/08/12, 15:35

    Verified; Looks good to me, but someone else must approve
  3. Philipp Gampe commented on patch set 1 05/08/12, 15:35

    Looks good to me, but someone else must approve
  4. Georg Ringer commented on patch set 1 V 0 05/08/12, 15:35

    by team member; Looks good to me, approved
  5. Georg Ringer merged patch set 1 05/08/12, 15:35