Review main Merged

9891[BUGFIX] Missing column in t3lib_TCEmain::getPreviousLocalizedRecordUid

Francois Suter CR +2 V +2 Easy +4 −0 updated 06/03/13, 20:49

Commit message

Method t3lib_TCEmain::getPreviousLocalizedRecordUid() checks for the
"closest" localized record. For content elements it does this per
column, but actually fails because the "colPos" field is not among
the available fields. It must be added to the selection.

Review

  • Code review CR +2
    • Francois Suter +2
    • Georg Ringer +1
    • Wouter Wolters +1
    • Philipp Gampe +1
  • Verified V +2
    • Francois Suter +2
    • Georg Ringer +1

Files 1

Review log 6

  1. Francois Suter commented on patch set 1 V 0 03/28/12, 06:33

    by team member; Looks good to me, approved Thanks for the feedback. I would also say it's a no-brainer, so I'm going ahead.
  2. Georg Ringer commented on patch set 1 03/28/12, 06:33

    Verified; Looks good to me, but someone else must approve
  3. Philipp Gampe commented on patch set 1 03/28/12, 06:33

    Looks good to me, but someone else must approve nobrainer IMHO
  4. Mr. Jenkins commented on patch set 1 03/28/12, 06:33

  5. Wouter Wolters commented on patch set 1 03/28/12, 06:33

    Looks good to me, but someone else must approve
  6. Francois Suter merged patch set 1 03/28/12, 06:33