9894[BUGFIX] Installer fails on having some field names in SQL
Commit message
Review
-
Code review CR 0
-
Verified V 0
Files 1
Review log 33
Show 8 earlier messages
-
Dmitry Dulepov commented on patch set 1 05/27/13, 17:19
(3 inline comments)class.t3lib_install_sql.php:452If you escape the table name above, should it be escaped here too?class.t3lib_install_sql.php:456...and here...class.t3lib_install_sql.php:460..and here. -
Oliver Klee commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Kay Strobach commented on patch set 1 05/27/13, 17:19
(3 inline comments)class.t3lib_install_sql.php:452ReplyDoneclass.t3lib_install_sql.php:456ReplyDoneclass.t3lib_install_sql.php:460ReplyDone -
Kay Strobach commented on patch set 1 05/27/13, 17:19
sure, sry, i missed them :( - i'll do a reupload - thanks -
Kay Strobach commented on patch set 1 05/27/13, 17:19
the patch is made for 4.7, hints for 4.6 and 4.5 are available in the forge ticket #35253 -
Stefan Neufeind commented on patch set 2 1 comment 05/27/13, 17:19
Looks good to me, but someone else must approve didn't spot an error during reading -
Dmitry Dulepov commented on patch set 3 05/27/13, 17:19
Looks good to me, but someone else must approve @Philipp Gampe: yes, dbal support that (took me 3 mins to look into the code). -
Dmitry Dulepov commented on patch set 3 V 0 05/27/13, 17:19
by team member Verified.
-
Xavier Perseguers commented on patch set 3 05/27/13, 17:19
(1 inline comment) -
Xavier Perseguers uploaded patch set 3 05/27/13, 17:19
-
Stefan Neufeind commented on patch set 4 05/27/13, 17:19
Looks good to me, but someone else must approve -
Xavier Perseguers uploaded patch set 4 05/27/13, 17:19
-
Xavier Perseguers commented on patch set 4 05/27/13, 17:19
Verified; Looks good to me, but someone else must approve -
Kay Strobach uploaded patch set 2 05/27/13, 17:19
-
Kay Strobach commented on patch set 3 05/27/13, 17:19
thanks for reviewing, i really had forgotten, that i made this patch a year ago ... guess what? -
Sebastian Fischer commented on patch set 1 05/27/13, 17:19
Looks good to me, but someone else must approve -
Philipp Gampe commented on patch set 2 05/27/13, 17:19
Did you test this with dbal or can dbal handle that? -
Mr. Jenkins commented on patch set 1 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3660/ : SUCCESS -
Mr. Jenkins commented on patch set 2 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3668/ : SUCCESS -
Mr. Jenkins commented on patch set 3 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/6304/ : SUCCESS -
Mr. Jenkins commented on patch set 4 05/27/13, 17:19
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/7613/ : SUCCESS -
Wouter Wolters commented on patch set 3 1 comment 05/27/13, 17:19
Looks good to me, but someone else must approve -
Alexander Opitz uploaded patch set 5 07/03/13, 13:22
-
Mr. Jenkins commented on patch set 5 07/03/13, 13:22
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/9338/ : SUCCESS -
Alexander Opitz commented on patch set 5 V +1 CR +1 07/03/13, 13:23
Rebased -
Stefan Neufeind commented on patch set 5 CR +1 07/06/13, 12:47
add 6.04.7 is security-bugfixes only and it might be that some will argue it's not critical enough for 4.5 So maybe just 6.x-series? -
Jigal van Hemert commented on patch set 5 CR -1 07/07/13, 09:41
I really fear that introducing reserved SQL words as column names in TYPO3 will result in loads of problems (SQL errors). Try \TYPO3\CMS\Backend\Utility\BackendUtility::getRecordsByField('mytable', 'group', '5'); it will result in this query: SELECT * FROM mytable WHERE group = 5; which will of course lead to an SQL error. Same goes for sorting on these fields in the List module and many other occasions. Introducing support for reserved words as column names requires a lot more changes than just this function. DBAL probably needs to add support in the query parser (I only see support for backticks in the ALTER TABLE parser). The minimum would be that all query, database and record related functions have unit tests with some reserved words to check if they are quoted. MySQL and SQL Server can optionally use ANSI quotes (double quotes for identifiers, single quotes for strings), but this will most likely lead to compatibility problems with existing code. I'm leaning towards a -2 . -
Stefan Neufeind commented on patch set 5 07/07/13, 11:41
@Kay: What exact usecase did you have in mind when you created this issue/patch? Might it possibly be a good idea to abandon it for now but maybe open a new issue to fully support reserved words (as Jigal explained)? That would be a larger task then - proper quoting of names everywhere. -
Stefan Neufeind commented on patch set 5 04/04/14, 14:07
Imho we should really get this resolved somehow. So what are our options? Imho using backticks "where needed" (catch as much places as we can at least) and in DBAL take special care that backticks are properly transformed then into single-quotes or whatever the DBMS might need? -
Kay Strobach commented on patch set 5 04/04/14, 14:10
the problem originally occurend during the development of piwikintegration. i would be fine with denying these names in the TYPO3 DB API directly, or otherwise allow backticks, which then forces a dependency to mysql. @jigal, take a look in the forge issue, there you see the problematic queries. -
Jigal van Hemert commented on patch set 5 04/04/14, 15:00
This breaks DBAL, so it's a no-go to include this in the core for me. Simply not using reserved names as column/table/index names is an easy solution. -
Kay Strobach commented on patch set 5 09/07/14, 13:03
sadly it isn't especially if you integrate with some libraries and other software ... but for now i abondon this RFC -
Kay Strobach abandoned the change 09/07/14, 13:03