Review main Merged

9966[FEATURE] Add stdWrap to cObject USER.

mostwanted CR +2 V +2 Easy +3 −0 updated 06/03/13, 20:49

Commit message

Review

  • Code review CR +2
    • Stefan Galinski +2
    • Markus Klein +1
    • Philipp Gampe +1
  • Verified V +2
    • Stefan Galinski +2
    • Markus Klein +1

Files 1

Review log 21

  1. mostwanted commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  2. mostwanted commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  3. mostwanted commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  4. mostwanted commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  5. mostwanted commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  6. mostwanted commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  7. Markus Klein commented on patch set 2 04/13/12, 16:25

    Verified; Looks good to me, but someone else must approve
  8. Stefan Galinski commented on patch set 2 04/13/12, 16:25

    Verified; Looks good to me, but someone else must approve
  9. mostwanted uploaded patch set 2 04/13/12, 16:25

  10. mostwanted commented on patch set 2 04/13/12, 16:25

    I changed the target release to 6.0. would be great if the change request is fine now.
  11. mostwanted commented on patch set 2 04/13/12, 16:25

  12. Georg Ringer commented on patch set 1 04/13/12, 16:25

    I would prefer that you didn't submit this
    if it is a feature, it can go only in master = Releases: 6.0 if it is a bugfix, then it could go into other branches. so please change to Releases: 6.0, however it can be later still be backported
  13. Chris topher commented on patch set 2 04/13/12, 16:25

    Please post the link to the issue in the TSref project, so that the documentation update is not forgotten.
  14. Philipp Gampe commented on patch set 1 04/13/12, 16:25

    (1 inline comment)

    Reply

    We always handled adding of stdWrap as a feature. so 6.0 only.

    Reply

    must be origin/master
  15. Philipp Gampe commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  16. Philipp Gampe commented on patch set 2 04/13/12, 16:25

    Looks good to me, but someone else must approve
  17. Mr. Jenkins commented on patch set 1 04/13/12, 16:25

  18. Wouter Wolters commented on patch set 1 04/13/12, 16:25

    (1 inline comment)

    Reply

    No you don't have to wait. You can already submit you're feature request for 6.0/master. 4.7 is already as branch available but not released yet (24 april).

    Reply

    My bad, you already submitted for 6.0. 6.0 = master. The only thing you need to change is the Releases line:) mention only 6.0 there
  19. Wouter Wolters commented on patch set 1 04/13/12, 16:25

    (1 inline comment)
  20. Stefan Galinski commented on patch set 2 V 0 04/13/12, 16:25

    by team member; Looks good to me, approved Thanks for your contribution! :-)
  21. Stefan Galinski merged patch set 2 04/13/12, 16:25