9966[FEATURE] Add stdWrap to cObject USER.
Commit message
Review
-
Code review CR +2
- Stefan Galinski +2
- Markus Klein +1
- Philipp Gampe +1
-
Verified V +2
- Stefan Galinski +2
- Markus Klein +1
Files 1
Review log 21
-
mostwanted commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
mostwanted commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
mostwanted commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
mostwanted commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
mostwanted commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
mostwanted commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
Markus Klein commented on patch set 2 04/13/12, 16:25
Verified; Looks good to me, but someone else must approve -
Stefan Galinski commented on patch set 2 04/13/12, 16:25
Verified; Looks good to me, but someone else must approve -
mostwanted uploaded patch set 2 04/13/12, 16:25
-
mostwanted commented on patch set 2 04/13/12, 16:25
I changed the target release to 6.0. would be great if the change request is fine now. -
mostwanted commented on patch set 2 04/13/12, 16:25
-
Georg Ringer commented on patch set 1 04/13/12, 16:25
I would prefer that you didn't submit thisif it is a feature, it can go only in master = Releases: 6.0 if it is a bugfix, then it could go into other branches. so please change to Releases: 6.0, however it can be later still be backported -
Chris topher commented on patch set 2 04/13/12, 16:25
Please post the link to the issue in the TSref project, so that the documentation update is not forgotten. -
Philipp Gampe commented on patch set 1 04/13/12, 16:25
(1 inline comment)Reply
We always handled adding of stdWrap as a feature. so 6.0 only.Reply
must be origin/master -
Philipp Gampe commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
Philipp Gampe commented on patch set 2 04/13/12, 16:25
Looks good to me, but someone else must approve -
Mr. Jenkins commented on patch set 1 04/13/12, 16:25
Build Successful https://ci.typo3.org/job/typo3-v4-core-gerrit/3675/ : SUCCESS -
Wouter Wolters commented on patch set 1 04/13/12, 16:25
(1 inline comment)Reply
No you don't have to wait. You can already submit you're feature request for 6.0/master. 4.7 is already as branch available but not released yet (24 april).Reply
My bad, you already submitted for 6.0. 6.0 = master. The only thing you need to change is the Releases line:) mention only 6.0 there -
Wouter Wolters commented on patch set 1 04/13/12, 16:25
(1 inline comment) -
Stefan Galinski commented on patch set 2 V 0 04/13/12, 16:25
by team member; Looks good to me, approved Thanks for your contribution! :-) -
Stefan Galinski merged patch set 2 04/13/12, 16:25