Review 13.4 Merged

87600[TASK] Avoid invalid reuse of QueryBuilder in Typo3DatabaseBackend

Stefan Bürk CR +2 V +2 Easy +1 −0 updated 12/29/24, 09:17

Commit message

Reuse of a QueryBuilder instance for multiple queries and
specifically different types (UPDATE/DELETE/SELECT/...) is
not recommended and **must** be avoided.

This change creates a new instance within a method of the
Typo3DatabaseBackend, dealing with multiple queries in one
method. This prevents previous settings to affect
the actual query.

This issue was detected with implementation of #105387.

Review

  • Code review CR +2 Done
    • Stefan Bürk +2
  • Verified V +2 Done
    • Stefan Bürk +2
    • core-ci +1 CI

Issues 2

Files 1

Review log 34

  1. Stefan Bürk commented on patch set 1 12/29/24, 08:59

    Cherry Picked from branch main.
  2. core-ci voted on patch set 1 V +1 12/29/24, 09:13 Core CI is happy: https://git.typo3.org/typo3/CI/cms/-/pipelines/71699

  3. Stefan Bürk voted on patch set 1 CR +2 V +2 12/29/24, 09:17

  4. Stefan Bürk merged patch set 2 12/29/24, 09:17