#100856SilentConfigurationUpgradeService removed FE/versionNumberInFilename setting
Description
There seems to be an error in the logic of \TYPO3\CMS\Install\Service\SilentConfigurationUpgradeService::migrateVersionNumberInFileNameSetting():
The option is always removed, when the value is not embed:
if ($currentOption === 'embed') {
$confManager->setLocalConfigurationValueByPath('FE/versionNumberInFilename', true);
} else {
$confManager->removeLocalConfigurationKeysByPath(['FE/versionNumberInFilename']);
}
This does not seem to make sense because the value is also removed, when it is set to true.
Am I missing something here or this be a conditional else, something like:
if ($currentOption === 'embed') {
...
} elseif (!$currentOption) {
$confManager->removeLocalConfigurationKeysByPath(['FE/versionNumberInFilename']);
}