Issue Bug Closed

#100856SilentConfigurationUpgradeService removed FE/versionNumberInFilename setting

Alexander Stehlik 05/10/23, 21:15 updated 07/09/24, 12:56

Description

There seems to be an error in the logic of \TYPO3\CMS\Install\Service\SilentConfigurationUpgradeService::migrateVersionNumberInFileNameSetting():

The option is always removed, when the value is not embed:

if ($currentOption === 'embed') {
    $confManager->setLocalConfigurationValueByPath('FE/versionNumberInFilename', true);
} else {
    $confManager->removeLocalConfigurationKeysByPath(['FE/versionNumberInFilename']);
}

This does not seem to make sense because the value is also removed, when it is set to true.

Am I missing something here or this be a conditional else, something like:

if ($currentOption === 'embed') {
...
} elseif (!$currentOption) {
    $confManager->removeLocalConfigurationKeysByPath(['FE/versionNumberInFilename']);
}

Reviews 2