#100934Typolink soft reference parsers does not consider links to currrent page
Description
… if format t3://page?uid=current is used.
This manifests itself in
- links to current page with wrong anchor are not reported as broken in linkvalidator, see #100933
- no reference index entries are created for links to current page (this is described below)
- …?
no reference index entries are created for links to current page
Reproduce
- create several links (see below) as page links, to current page, with anchor
- update the reference index
- check the database entries in the reference index
Expected result
The result should be the same whether t3://page?uid=current or t3://page?uid=<current page id> are used. So either it creates a reference index in both cases or it does not create one at all.</current>
Actual result
The result is not the same:
No reference index entries are created for the links to current page (of format t3://page?uid=current or t3://page?uid=current#<anchor>). You can search for them by using the CE id, e.g.</anchor>
select tablename,recuid,field,softref_key,softref_id,ref_table,ref_uid,ref_string from sys_refindex where tablename='tt_content' and (recuid=36 or recuid=37);
2 reference index entries are created for this link with target URL:
t3://page?uid=209#38
select tablename,recuid,field,softref_key,softref_id,ref_table,ref_uid,ref_string from sys_refindex where tablename='tt_content' and (recuid=38); +------------+--------+----------+--------------+------------------------------------+------------+---------+------------+ | tablename | recuid | field | softref_key | softref_id | ref_table | ref_uid | ref_string | +------------+--------+----------+--------------+------------------------------------+------------+---------+------------+ | tt_content | 38 | bodytext | typolink_tag | 1 | pages | 209 | | | tt_content | 38 | bodytext | typolink_tag | d5747c9ecb74651c68d8215ed0c095ac:1 | tt_content | 38 | | +------------+--------+----------+--------------+------------------------------------+------------+---------+------------+
No reference index entries are created for this link with target URL:
t3://page?uid=current#38
No reference index entries are created for this link with target URL:
t3://page?uid=current
Source code
This seems to be due to TypolinkTagSoftReferenceParser::parse not considering links with the format t3://page?uid=current#99999999. The parser does not return the t3://page?uid=current links.
This also concerns TypolinkSoftReferenceParser.
code:
} elseif ($linkDetails['type'] === LinkService::TYPE_PAGE && preg_match('/page\?uid=(\d+)#?(\d+)?/', $matches[1], $pageAndAnchorMatches)) {
Reviews 1
Related issues 3
History 832
Show 57 earlier messages
-
Sybille Peters changed Related to #100933 <span data-processor="relativetime" data-value="2023-05-31T07:16:37+00:00" > 05/31/23, 07:16 </span>
-
Sybille Peters changed Related to #100935 <span data-processor="relativetime" data-value="2023-05-31T07:19:52+00:00" > 05/31/23, 07:19 </span>
-
Sybille Peters changed description <span data-processor="relativetime" data-value="2023-05-31T09:23:12+00:00" > 05/31/23, 09:23 </span>
-
Sybille Peters changed subject
Softref parser TypolinkTagSoftReferenceParser does not consider links to currrent pageSoftref parser Typolink soft reference parsers does not consider links to currrent page <span data-processor="relativetime" data-value="2023-05-31T09:23:36+00:00" > 05/31/23, 09:23 </span> -
Sybille Peters changed subject
Softref parser Typolink soft reference parsers does not consider links to currrent pageTypolink soft reference parsers does not consider links to currrent page <span data-processor="relativetime" data-value="2023-05-31T09:23:49+00:00" > 05/31/23, 09:23 </span> -
Gerrit Code Review pushed patch set 1 for main to change 79154 status
NewUnder Review <span data-processor="relativetime" data-value="2023-05-31T09:57:41+00:00" > 05/31/23, 09:57 </span> -
Gerrit Code Review pushed patch set 2 for main to change 79154 <span data-processor="relativetime" data-value="2023-05-31T10:05:05+00:00" > 05/31/23, 10:05 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 79154 <span data-processor="relativetime" data-value="2023-05-31T10:24:36+00:00" > 05/31/23, 10:24 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 79154 <span data-processor="relativetime" data-value="2023-05-31T11:13:59+00:00" > 05/31/23, 11:13 </span>
-
Gerrit Code Review pushed patch set 5 for main to change 79154 <span data-processor="relativetime" data-value="2023-05-31T12:27:50+00:00" > 05/31/23, 12:27 </span>
-
Gerrit Code Review pushed patch set 6 for main to change 79154 <span data-processor="relativetime" data-value="2023-05-31T13:32:35+00:00" > 05/31/23, 13:32 </span>
-
Sybille Peters commented <span data-processor="relativetime" data-value="2023-06-01T06:36:10+00:00" > 06/01/23, 06:36 </span>
-
Gerrit Code Review pushed patch set 7 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T07:44:20+00:00" > 06/01/23, 07:44 </span>
-
Gerrit Code Review pushed patch set 8 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T08:01:10+00:00" > 06/01/23, 08:01 </span>
-
Gerrit Code Review pushed patch set 9 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T08:05:15+00:00" > 06/01/23, 08:05 </span>
-
Gerrit Code Review pushed patch set 10 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T08:30:56+00:00" > 06/01/23, 08:30 </span>
-
Gerrit Code Review pushed patch set 11 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T09:32:10+00:00" > 06/01/23, 09:32 </span>
-
Gerrit Code Review pushed patch set 12 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T10:01:13+00:00" > 06/01/23, 10:01 </span>
-
Gerrit Code Review pushed patch set 13 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T10:50:27+00:00" > 06/01/23, 10:50 </span>
-
Gerrit Code Review pushed patch set 14 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T11:59:17+00:00" > 06/01/23, 11:59 </span>
-
Gerrit Code Review pushed patch set 15 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-01T12:21:17+00:00" > 06/01/23, 12:21 </span>
-
Gerrit Code Review pushed patch set 16 for main to change 79154 <span data-processor="relativetime" data-value="2023-06-03T08:42:06+00:00" > 06/03/23, 08:42 </span>
-
Gerrit Code Review pushed patch set 17 for main to change 79154 <span data-processor="relativetime" data-value="2023-08-03T21:39:25+00:00" > 08/03/23, 21:39 </span>
-
Gerrit Code Review pushed patch set 18 for main to change 79154 <span data-processor="relativetime" data-value="2023-08-12T09:13:46+00:00" > 08/12/23, 09:13 </span>
-
Gerrit Code Review pushed patch set 19 for main to change 79154 <span data-processor="relativetime" data-value="2023-08-12T14:48:34+00:00" > 08/12/23, 14:48 </span>
-
Gerrit Code Review pushed patch set 20 for main to change 79154 <span data-processor="relativetime" data-value="2023-08-24T05:14:27+00:00" > 08/24/23, 05:14 </span>
-
Gerrit Code Review pushed patch set 21 for main to change 79154 <span data-processor="relativetime" data-value="2023-08-24T05:40:05+00:00" > 08/24/23, 05:40 </span>
-
Christian Kuhn changed Related to #94562 <span data-processor="relativetime" data-value="2024-11-20T15:09:14+00:00" > 11/20/24, 15:09 </span>
-
Sybille Peters changed description <span data-processor="relativetime" data-value="2025-04-06T07:16:35+00:00" > 04/06/25, 07:16 </span>
-
Gerrit Code Review pushed patch set 22 for main to change 79154 <span data-processor="relativetime" data-value="2025-04-06T07:59:11+00:00" > 04/06/25, 07:59 </span>
-
Gerrit Code Review pushed patch set 23 for main to change 79154 <span data-processor="relativetime" data-value="2026-09-25T18:36:07+00:00" > 09/25/26, 18:36 </span>
-
Gerrit Code Review pushed patch set 24 for main to change 79154 <span data-processor="relativetime" data-value="2026-10-02T11:56:43+00:00" > 10/02/26, 11:56 </span>
There is the problem that the page uid is currently not passed to and not known in the softref parser. However, it is necessary to properly resolve the “current” page.
Following a discussion on Slack in the coredev channel, here are some possible solutions with their caveats:
Slack:
1. Change the signature for the parse function in the softref parsers in general to pass the $row (with pid) as optional parameter:
2. fetch the page uid based on the uid in the softref parser:
3. Leave the functionality as is except do not convert the page id to int if it contains “current”, meaning pass through the “current” page uid and let the calling function worry about it
4. Add additional function to add the page uid only to the softref parsers which require it