Issue Bug Closed

#101875TYPO3 v.12 | Graphics Magick does not work!!!

Claus Harup 09/07/23, 13:46 updated 07/09/24, 15:19

Description

In \typo3\cms-install\Classes\Configuration\Image\GraphicsMagickPreset.php findGraphicsMagickInPaths gets called with:

[
        '/usr/local/bin/',
        '/opt/local/bin/',
        '/usr/bin/',
        '/usr/X11R6/bin/',
        '/opt/bin/',
        'C:/php/ImageMagick/',
        'C:/php/GraphicsMagick/',
        'C:/apache/ImageMagick/',
        'C:/apache/GraphicsMagick/',
    ]
protected function findGraphicsMagickInPaths(array $searchPaths)
    {
        $result = false;
        foreach ($searchPaths as $path) {
            if (Environment::isWindows()) {
                $executable = 'gm.exe';
            } else {
                $executable = 'gm';
            }

            $binaryPath = $path . $executable;
            if (!file_exists($binaryPath) || !is_executable($binaryPath)) {
                break;
            }

            $command = escapeshellarg($binaryPath) . ' -version';
            $executingResult = [];
            @CommandUtility::exec($command, $executingResult);
            // First line of exec command should contain string GraphicsMagick
            $firstResultLine = array_shift($executingResult);
            if (is_string($firstResultLine) && str_contains($firstResultLine, 'GraphicsMagick')) {
                $this->foundPath = $path;
                $result = true;
                break;
            }
        }

        return $result;
    }

The break makes it imposible to reach to our path [/usr/bin/]……

Please replace the break with continue :-)

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.