Issue Bug Closed

#103122FileLinkHandler: false return value not taken into account

Gernot Leitgab 02/14/24, 14:27 updated 07/09/24, 15:33

Description

With the latest security patch version 11.5.35 the following lines where added to “\TYPO3\CMS\Recordlist\LinkHandler\FileLinkHandler::render()”:

        if ($selectedFolder->getStorage()->isFallbackStorage()) {
            $selectedFolder = null;
        }

https://github.com/TYPO3-CMS/recordlist/compare/v11.5.34…v11.5.35#diff-606331e26a505d19f3d851b0ac8c71433f861a2074c9e31b5077088e7d8e69e1

The variable “$selectedFolder” can be “false”, because the previous line is “$selectedFolder = $this->getSelectedFolder($this->expandFolder);” and the return value of “getSelectedFolder()” can be a folder object or “false”. The “false” return value is not taken into account in the newly added code, which results in an exception.

Reviews 1