#104057Singleton instances are not possible for LogWriter
Description
This leads to the InMemoryLogWriter of the admin panel to be instaciated as new class. Therefor all the logs will not be shown, because they got written in another instance.
The problem lies in the LogManager and GeneralUtiliy:makeInstance
The line $logWriter = GeneralUtility::makeInstance($logWriterClassName, $logWriterOptions); when $logWriterOptions=[]
Then GeneralUtiliy:makeInstance will not get the container:
if (self::$container !== null && $constructorArguments === [] && self::$container->has($className)) {
return self::$container->get($className);
}Reviews 1
History 15
-
Eike Starkmann changed description <span data-processor="relativetime" data-value="2024-06-11T15:04:34+00:00" > 06/11/24, 15:04 </span>
-
Gerrit Code Review pushed patch set 1 for main to change 84620 status
NewUnder Review <span data-processor="relativetime" data-value="2024-06-11T15:26:55+00:00" > 06/11/24, 15:26 </span> -
Gerrit Code Review pushed patch set 2 for main to change 84620 <span data-processor="relativetime" data-value="2024-06-11T16:40:23+00:00" > 06/11/24, 16:40 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 84620 <span data-processor="relativetime" data-value="2024-10-18T13:33:53+00:00" > 10/18/24, 13:33 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 84620 <span data-processor="relativetime" data-value="2026-04-22T06:56:11+00:00" > 04/22/26, 06:56 </span>