#104133SelectCheckBoxElement is broken as data-multi-record-selection must trigger data-is-dirty on checkbox-change
Description
The data-multi-record-selection JS-implementation looks like it was intended to be used for temporary selection of records in the TYPO3 backend – e.g. content-element-records selected in a list-view for ‘copy to clipboard’-feature.
By sprint in https://forge.typo3.org/issues/104012 data-multi-record-selection became the new UI for SelectCheckBoxElement.
But data-multi-record-selection currently does not handle the neccessary features for multi-select-checkboxes which are stored in a database-field.
Especially checkbox-state changes triggered by click on background behind checkbox or toggle-menu must have the following features implemented:
- Trigger data-is-dirty on checkbox change to make a dialogue ‘Do you want to close without saving?’ appear.
- Respect disabled checkboxes and don’t change their state.
Reviews 0
No change resolves or names this issue in its commit message, and no comment links one.
Related issues 3
Files 2
History 9
-
Ayke Halder changed description <span data-processor="relativetime" data-value="2024-06-17T15:32:54+00:00" > 06/17/24, 15:32 </span>
-
Ayke Halder changed Related to #104012 <span data-processor="relativetime" data-value="2024-06-17T15:42:48+00:00" > 06/17/24, 15:42 </span>
-
Ayke Halder changed Related to #103521 <span data-processor="relativetime" data-value="2024-06-17T15:43:10+00:00" > 06/17/24, 15:43 </span>
-
Ayke Halder commented and changed attached typo3-be-checkbox-with-data_dirty_dialogue.gif attached typo3-be-checkbox-no-data_dirty_dialogue.gif <span data-processor="relativetime" data-value="2024-06-17T15:46:35+00:00" > 06/17/24, 15:46 </span>
-
Riccardo De Contardi changed Related to #104142 <span data-processor="relativetime" data-value="2024-06-18T10:12:29+00:00" > 06/18/24, 10:12 </span>
-
Riccardo De Contardi commented and changed status
NewClosed <span data-processor="relativetime" data-value="2024-06-18T10:16:11+00:00" > 06/18/24, 10:16 </span>I close this issue as a duplicate of #104142 which has a patch attached. Please continue the discussion there
If you think that this is the wrong decision please reopen it or open a new issue with a reference to this one. Thank you.
-
Ayke Halder commented and changed subject
SelectCheckBoxElement is broken as data-multi-record-selection needs implementation for disabled checkboxes and must trigger data-is-dirty on checkbox-changeSelectCheckBoxElement is broken as data-multi-record-selection must trigger data-is-dirty on checkbox-change <span data-processor="relativetime" data-value="2024-06-18T12:19:18+00:00" > 06/18/24, 12:19 </span>This one was solved: data-multi-record-selection needs implementation for disabled checkboxes
This one is still open: data-multi-record-selection must trigger Data-is-dirty on checkbox change
-
Riccardo De Contardi commented and changed status
ClosedNew <span data-processor="relativetime" data-value="2024-06-18T12:47:30+00:00" > 06/18/24, 12:47 </span>Reopened on request of the reporter. Sorry for the inconvenience
-
Georg Ringer commented and changed status
NewClosed <span data-processor="relativetime" data-value="2026-10-02T19:21:01+00:00" > 10/02/26, 19:21 </span>thanks for the detailed report, can’t be reproduced on main, therefore closing the issue
Data-is-dirty on checkbox change
Click directly on the checkboxes:
Makes a dialogue ‘Do you want to close without saving?’ appear on switching away.
typo3-be-checkbox-with-data_dirty_dialogue.gif
Click on background:
There is no dialogue ‘Do you want to close without saving?’ on switching away.
typo3-be-checkbox-no-data_dirty_dialogue.gif