#104563Use classname instead of ID for getLogger in LoggerAwarePass
Description
Hello,
in my Services.yaml I have added following lines:
services:
TYPO3\CMS\Core\Database\ConnectionPool: ~
db.connection.default:
class: TYPO3\CMS\Core\Database\Connection
factory: ['@TYPO3\CMS\Core\Database\ConnectionPool', 'getConnectionByName']
arguments: ['%default_connection_name%']
As class “Connection” includes the “LoggerAwareTrait”, that class will be looped within the “LoggerAwarePass”.
There you have following lines:
$channel = $id;
if ($definition->getClass()) {
$reflectionClass = $container->getReflectionClass($definition->getClass(), false);
if ($reflectionClass) {
$channel = $this->getClassChannelName($reflectionClass) ?? $channel;
}
}
Please remember that $id is “db.connection.default” here which is not helpful for Logger. I prefer using the classname out of Definition:
$channel = $id;
if ($definition->getClass()) {
$reflectionClass = $container->getReflectionClass($definition->getClass(), false);
if ($reflectionClass) {
$channel = $this->getClassChannelName($reflectionClass) ?? $definition->getClass();
}
}
That way the logger was build up correctly again with a classname
Stefan