Issue Bug Rejected

#106211'tstamp' is hardcoded

Claus Harup 02/19/25, 13:57 updated 02/20/25, 13:08

Description

In LinkAnalyzer.php function recheckLinks ‘tstamp’ is hardcoded.

        $row = $queryBuilder->select('uid', 'pid', $GLOBALS['TCA'][$table]['ctrl']['label'], $field, 'tstamp')
        ->from($table)
        ->where(
         $queryBuilder->expr()->eq(
                    'uid',
                    $queryBuilder->createNamedParameter($recordUid, Connection::PARAM_INT)
                )
            )
            ->executeQuery()
            ->fetchAssociative();

        if (!$row) {
            // missing record: remove existing links
            $this->brokenLinkRepository->removeBrokenLinksForRecord($table, $recordUid);
            return;
        }
        if (($row['tstamp'] ?? 0) && $timestamp && ((int)($row['tstamp']) < $timestamp)) {
            // timestamp has not changed: no need to recheck
            return;
        }

‘tstamp’ should be derived from TCA[‘ctrl’][‘tstamp’]….

Reviews 0

No change resolves or names this issue in its commit message, and no comment links one.