Issue Bug Closed

#107481Constructing the PageRenderer requires a request

Helmut Hummel 09/17/25, 20:29 updated 11/09/26, 11:08

Description

This is because the constructor calls $this->reset() and in this method the
JavaScriptRenderer is created and a URI is generated, wich requires a request
to determine the correct URL prefix.

While this did not impose a problem until now, it will in the future, when
PageRendere receives a request object upon rendering, so that we can
get rid of global and super global request dependencies.

Reviews 1

History 25

  1. Benni Mack commented and changed status Under Review Closed <span data-processor="relativetime" data-value="2026-11-09T11:08:40+00:00" > 11/09/26, 11:08 </span>

    Resolved by #109286 (9399843e41f, Gerrit 91406, included since 14.x): PageRenderer::__construct() no longer needs a request, the JavaScriptRenderer only keeps the resource identifier and generates the URI when rendering, and reset() / setDocType() receive the request explicitly. Closing as duplicate of #109286.