Issue Bug Closed

#10831New preview window shows wrong behavior for new page in LIVE WS

Francois Suter 11/16/10, 12:18 updated 08/11/26, 08:46

Description

Having tested RFC #13610 pending in the core list, I was able to play with the new workspace preview. I found the following problem: assume that you have created a new page and are previewing it. The LIVE tab/frame used to show an (error) message in the previous versions of TYPO3:

“New page! The previewed page is created in the workspace and has no counterpart in the live workspace.”

This does not happen anymore. Instead we get a TYPO3 error about a broken rootline (which is correct in principle, but far less informative than the message that appeared before). This feature should not be lost.

Reviews 2

Files 2

History 1318

  1. Tolleiv Nietsch commented and changed status New Accepted <span data-processor="relativetime" data-value="2010-11-18T18:25:38+00:00" > 11/18/10, 18:25 </span>

    Absolutely right thanks for bringing that up

  2. Tolleiv Nietsch commented and changed done 0 % 90 % <span data-processor="relativetime" data-value="2010-11-24T18:33:20+00:00" > 11/24/10, 18:33 </span>

    pending as FYI48 in the typo3.team.workspaces newsgroup

  3. Tolleiv Nietsch commented and changed attached 10831v2.patch status Under Review Resolved done 90 % 100 % <span data-processor="relativetime" data-value="2010-11-29T18:10:03+00:00" > 11/29/10, 18:10 </span>

    Committed to trunk (rev. 3105)

  4. Francois Suter commented <span data-processor="relativetime" data-value="2010-11-29T20:36:16+00:00" > 11/29/10, 20:36 </span>

    I’m sorry but that doesn’t work, because you forgot to pass the $language parameter in the call tx_Workspaces_Service_Workspaces::isNewPage() (in the PreviewController.php, line 95).

    BTW, there’s a typo in the same file, the line just above: “supposed” => “supported”

  5. Gerrit Code Review pushed patch set 1 for main to change 95129 status Closed Under Review <span data-processor="relativetime" data-value="2026-08-06T19:15:45+00:00" > 08/06/26, 19:15 </span>

  6. Philip Kuban commented and changed status Under Review Resolved <span data-processor="relativetime" data-value="2026-08-06T22:45:09+00:00" > 08/06/26, 22:45 </span>

    Applied in changeset commit:83803c52f106513938fd4e0585851e385be2c795.