#108686Unsaved-Changes Dialog: Clear Button Hierarchy and Labeling
Description
In the “Close without saving” dialog, action labels are not clear and the visual/functional hierarchy of buttons is ambiguous. Users must quickly understand the prompt and distinguish primary from secondary/neutral actions. Accessibility (e.g., clear labels, logical focus order, sufficient contrast) must be ensured.
Reproduction Steps
- Edit a page/record.
- Attempt to close without saving (e.g., “Close”, browser back/navigation).
- “Close without saving” dialog appears.
- Observe: Button labels and order are unclear; hierarchy is hard to recognize.
Impact
- Increased risk of errors (e.g., unintended discard).
- Lower efficiency and higher frustration, especially for keyboard and screen reader users.
- Violations of UX/a11y principles (contrast, no color-only communication; clear naming).
Recommended Solution
- Primary action as a clearly highlighted primary button (e.g., “Save & close” or “Discard changes”) on the right; secondary/Cancel on the left.
- Clear, consistent labels; no icon-only actions. Use aria-label for icon controls.
- Logical focus order: title → body text → primary → secondary → cancel; tested with keyboard and screen readers per WCAG.
- Sufficient color contrast; do not rely on color alone to convey meaning.
Definition of Done
- New dialog structure and button order implemented and visually validated.
- Accessibility check: contrast, focus order, screen reader announcements (aria-label/role) passed.
- UX review approved; copy finalized.
- QA: Manual tests across key viewports; keyboard-only operation works reliably.
Acceptance Criteria
- Buttons have clear, unambiguous labels.
- Each action’s function is immediately recognizable (text + hierarchy).
- Visual and functional hierarchy is clear: Primary > Secondary > Cancel.
- Pop-up is clearly structured: meaningful title, short explanatory text, logically ordered actions.
- Keyboard navigation and screen reader output are correct;
- no color-only communication;
- sufficient contrast.
Reviews 1
Fix this issue
Start the commit message of your patch with this. Add what the patch does, and the versions it goes to in "Releases:". The changes above were merged or abandoned: read them before you start. How to create a patch
- Commit message
-
[BUGFIX] Unsaved-Changes Dialog: Clear Button Hierarchy and Labeling Resolves: #108686 Releases: main
History 01
-
Gerrit Code Review pushed patch set 1 for main to change 92622 status
NewUnder Review <span data-processor="relativetime" data-value="2026-02-02T11:12:52+00:00" > 02/02/26, 11:12 </span>