#108926File list: Link implemented as button
Description
The name of a file can be clicked on and operated using the keyboard. Interaction leads to a new page where the file details can be edited.
All references must be implemented as links; only actions such as opening a menu should be implemented as buttons.
Solution
Turn the button into an a element with href.
Note
The visible accessible name of the element is already available to sighted and blind users. It does not need to be additionally output in the title attribute, which is not available to most users anyway (only works reasonably well with a connected mouse).
Reviews 1
Files 1
History 59
-
Garvin Hicking commented and changed status
NewNeeds Feedback <span data-processor="relativetime" data-value="2026-02-10T19:50:58+00:00" > 02/10/26, 19:50 </span> -
Philipp Tautz commented <span data-processor="relativetime" data-value="2026-02-11T10:57:21+00:00" > 02/11/26, 10:57 </span>
Garvin Hicking wrote in #note-1:
> What should we make the href point to? Since its a modal content we don’t have a reak href, its a click event (which is probably why we picked it to be a button.
>
> Or would href=”#” be preferred then?Hi, I am working on the same project as Christian.
For us, there is no modal. What happens is, that you activate the button and a new window is “overlayed, but the url changes.
If deep linking is possible, it is not an action, but a navigation, even if the entire screen does not reload. This is one reason why Single Page Applications can be tricky.At least in v13, it does not open in a modal or dialog. A modal or dialog would stop you from interacting with the background elements.
So, this should be a link. A link with ‘#’ is never a good solution.
I hope this helps, but happy to add more info as needed :)
-
Georg Ringer commented <span data-processor="relativetime" data-value="2026-02-11T11:15:14+00:00" > 02/11/26, 11:15 </span>
in v14 it is a modal ;)
-
Christian Jung commented <span data-processor="relativetime" data-value="2026-02-11T13:12:13+00:00" > 02/11/26, 13:12 </span>
href=“#” or the modal in v14 would not be very helpful. If deep linking is not possible, the ticket can be closed again, or if there is another major change to the file list, this can be taken into account.
-
Christian Rath-Ulrich commented <span data-processor="relativetime" data-value="2026-10-22T11:38:29+00:00" > 10/22/26, 11:38 </span>
in TYPO3 15 the # link ans an id on the tr / card item works fine and sets an correkt fokus i will folow this aproache
-
Gerrit Code Review pushed patch set 1 for main to change 97000 status
Needs FeedbackUnder Review <span data-processor="relativetime" data-value="2026-10-22T11:43:48+00:00" > 10/22/26, 11:43 </span> -
Gerrit Code Review pushed patch set 2 for main to change 97000 <span data-processor="relativetime" data-value="2026-10-22T15:53:40+00:00" > 10/22/26, 15:53 </span>
-
Gerrit Code Review pushed patch set 3 for main to change 97000 <span data-processor="relativetime" data-value="2026-10-26T08:26:54+00:00" > 10/26/26, 08:26 </span>
-
Gerrit Code Review pushed patch set 4 for main to change 97000 <span data-processor="relativetime" data-value="2026-11-12T16:48:45+00:00" > 11/12/26, 16:48 </span>
What should we make the href point to? Since its a modal content we don’t have a reak href, its a click event (which is probably why we picked it to be a button.
Or would href=”#” be preferred then?