Issue Bug Closed

#109698Normalize backslashes in ZipService::verify()

Oliver Hader 04/23/26, 10:45 updated 08/11/26, 08:46

Description

see attached markdown (from https://github.com/TYPO3/typo3/security/advisories/GHSA-q27g-2874-c7wp)

—-

Moved to public issue tracked since this is not considered a security vulnerability.

Reviews 3

Files 2

History 1217

  1. Oliver Hader commented <span data-processor="relativetime" data-value="2026-04-23T14:53:52+00:00" > 04/23/26, 14:53 </span>

    It seems the ZipService is only used in the Extension Manager and the Language Pack Service (see previous advisory at https://typo3.org/security/advisory/typo3-core-sa-2019-024).

  2. Gerrit Code Review changed status New Under Review <span data-processor="relativetime" data-value="2026-04-23T14:54:10+00:00" > 04/23/26, 14:54 </span> Patch set 1 for branch *main* of project *Teams/Security/TYPO3v4-Core* has been pushed to the review server. It is available at https://review.typo3.org/c/Teams/Security/TYPO3v4-Core/+/93831

  3. Gerrit Code Review <span data-processor="relativetime" data-value="2026-04-24T05:50:19+00:00" > 04/24/26, 05:50 </span> Patch set 2 for branch *main* of project *Teams/Security/TYPO3v4-Core* has been pushed to the review server. It is available at https://review.typo3.org/c/Teams/Security/TYPO3v4-Core/+/93831

  4. Benjamin Franzke commented <span data-processor="relativetime" data-value="2026-04-29T08:44:49+00:00" > 04/29/26, 08:44 </span>

    Tested on Windows with PHP 8.2, could not confirm the mentioned vulnerability, since this case is handled by ZipArchive::extractTo().

    PHP even had CVE’s that fixed issues in this regard:

    Tested via:

    C:\Users\benja\src\sec-test>dir
     Verzeichnis von C:\Users\benja\src\sec-test
    
    29.04.2026  10:37    <DIR>          .
    29.04.2026  10:25    <DIR>          ..
    29.04.2026  10:35               203 createzip.php
    29.04.2026  10:33               129 unzip.php
                   2 Datei(en),            332 Bytes
                   2 Verzeichnis(se), 377.987.620.864 Bytes frei
    
    C:\Users\benja\src\sec-test>dir ..
    
     Verzeichnis von C:\Users\benja\src
    
    29.04.2026  10:25    <DIR>          .
    29.04.2026  10:35    <DIR>          ..
    29.04.2026  10:37    <DIR>          sec-test
                   0 Datei(en),              0 Bytes
                   3 Verzeichnis(se), 377.987.620.864 Bytes frei
    
    C:\Users\benja\src\sec-test>more createzip.php
    <?php
    $zipFile = 'backslash_traversal.zip';
    $zip = new \ZipArchive();
    $zip->open($zipFile, \ZipArchive::CREATE);
    $zip->addFromString('foo\\..\\..\\bar2.php', '<?php echo "pwned";');
    $zip->close();
    
    C:\Users\benja\src\sec-test>C:\php\php createzip.php
    
    C:\Users\benja\src\sec-test>more unzip.php
    <?php
    $zipFile = 'backslash_traversal.zip';
    $zip = new \ZipArchive();
    $zip->open($zipFile);
    $zip->extractTo('.');
    $zip->close();
    
    C:\Users\benja\src\sec-test>C:\php\php unzip.php
    
    C:\Users\benja\src\sec-test>dir ..
    
     Verzeichnis von C:\Users\benja\src
    
    29.04.2026  10:25    <DIR>          .
    29.04.2026  10:35    <DIR>          ..
    29.04.2026  10:38    <DIR>          sec-test
                   0 Datei(en),              0 Bytes
                   3 Verzeichnis(se), 377.988.345.856 Bytes frei
    
    C:\Users\benja\src\sec-test>dir .
    
     Verzeichnis von C:\Users\benja\src\sec-test
    
    29.04.2026  10:38    <DIR>          .
    29.04.2026  10:25    <DIR>          ..
    29.04.2026  10:38               153 backslash_traversal.zip
    29.04.2026  10:38                19 bar2.php
    29.04.2026  10:35               203 createzip.php
    29.04.2026  10:33               129 unzip.php
                   4 Datei(en),            504 Bytes
                   2 Verzeichnis(se), 377.988.345.856 Bytes frei
    
    C:\Users\benja\src\sec-test>

    The traversal attempt did not work, since PHP assured the malicious file bar2.php is extracted to the destination directory and not above/outside.

    For this reason I’d handle this as a nice-to-have public harderning, but not as a security fix.

  5. Oliver Hader commented and changed attached Screenshot 2026-04-29 at 13.25.46.png <span data-processor="relativetime" data-value="2026-04-29T11:37:21+00:00" > 04/29/26, 11:37 </span>

    I can confirm this is not vulnerability on Windows.

  6. Oliver Hader commented <span data-processor="relativetime" data-value="2026-04-29T14:14:18+00:00" > 04/29/26, 14:14 </span>

    Moved to public issue tracked since this is not considered a security vulnerability.

    → pending review https://review.typo3.org/c/Packages/TYPO3.CMS/+/93882

  7. Oliver Hader changed project id category target version Field 19 kodareef5 Field 13 2026042310000016 <span data-processor="relativetime" data-value="2026-04-29T14:14:26+00:00" > 04/29/26, 14:14 </span>

  8. Oliver Hader changed subject ZipService::verify() path traversal bypass via backslash directory separators on Windows Normalize backslashes in ZipService::verify() <span data-processor="relativetime" data-value="2026-04-29T14:15:07+00:00" > 04/29/26, 14:15 </span>

  9. Oliver Hader commented and changed status Under Review Resolved done 0 % 100 % <span data-processor="relativetime" data-value="2026-04-30T06:30:12+00:00" > 04/30/26, 06:30 </span>

    Applied in changeset commit:18eddcc32337fe06bb34936167d3c438bbd58440.